feat: Improve console output to show packet enum names (magic_enum) #1344
Conversation
Space macros out utilize cache locality ensure no lost functionality
This reverts commit 33fa5f8.
change function handle formatting and function definition tweaks
jadebenn
changed the title
|
Marking as draft because I had an epiphany about how to make the performance of our magic_enum implementation equal or exceed that of the preprocessor implementation. I will test this later, but here's the idea: Instead of directly using the enum_name() function magic_enums provides, I will create a wrapper function called "StringifiedEnum" that defines a static const std::array provided by magic_enum's similarly-named enum_names() function. This function will then pass a reference to the corresponding array entry to the calling function. So, this should load a single copy of the pre-sorted(?) std::array into memory at compile-time, and it will be templated-out so those arrays are only generated for the enums this function is called on. This should essentially eliminate any and all performance overhead magic_enums could possibly impose, as after compilation only an array of entries corresponding to the enum would exist, and a function to access it. |
|
That's it for me. Ready to merge this when you all are. |
Replaces #1340. Adds magic_enum as a dependency in order to enable enum reflection and display world and packet message enum strings in the server output.